Missing patchnote line: warden DoTs renamed in combat log

[l6rp24e57]

Applies to Power Attack and Mighty Blow at least. Maybe Unerring Strike too, didnt check.

This appeared somewhere between U31.0.1 and U31.1.

Before the change:

Sp-Shi-Fi gambit:

[subject name] scored a [critical]/[devastating]/[partially evaded]/[partially parried]/[partially blocked] hit with Power Attack on [target name] for [value] [damage type] damage to Morale.

Its DoT:

[subject name] scored a [critical] hit with Low Bleed on [target name] for [value] [damage type] damage to Morale.

Sp-Shi-Fi-Sp gambit:

[subject name] scored a [critical]/[devastating]/[partially evaded]/[partially parried]/[partially blocked] hit with Mighty Blow on [target name] for [value] [damage type] damage to Morale.

Its DoT:

[subject name] scored a [critical] hit with Medium Bleed on [target name] for [value] [damage type] damage to Morale.

After the change:

Sp-Shi-Fi gambit:

[subject name] scored a [critical]/[devastating]/[partially evaded]/[partially parried]/[partially blocked] hit with Power Attack on [target name] for [value] [damage type] damage to Morale.

Its DoT:

[subject name] scored a [critical] hit with Power Attack Bleed on [target name] for [value] [damage type] damage to Morale.

Sp-Shi-Fi-Sp gambit:

[subject name] scored a [critical]/[devastating]/[partially evaded]/[partially parried]/[partially blocked] hit with Mighty Blow on [target name] for [value] [damage type] damage to Morale.

Its DoT:

[subject name] scored a [critical] hit with Mighty Blow Bleed on [target name] for [value] [damage type] damage to Morale.

This should have been at least mentioned in the patchnote, but better if this was reverted. Having the same name on the DoT as it is on the DoT-applying attack cross-interferes the triggers on DoT tracking plugins and renders some of them unusable/malfunctioning.

[Gandolf_TheOld]

Power Attack is a low-level bleed and Power Attack Bleed is nothing more than SSG directly connecting the damage to the gambit.

Every plugin author knows that SSG could change things at any time. It is now up to the plugin author to change their plugin to conform with this change.

Agreed, SSG should have mentioned this. SSG does not have to revert this change, it is the plugin that needs to be changed.

This change also follows the programming principle of self-documenting, now you'll more easily know which gambit is doing what.

[bohbashum]

There working on warden... interesting...

Just the fact they have eyes on it under the hood seems like the first time in a while.

Very odd to see this change out the blue. Been like this since launch of warden?

[andys90]

Next step change the bleed icons so they aren't identical. Even just a 1/2/3 on them would do.

[l6rp24e57]

Power Attack is a low-level bleed and Power Attack Bleed is nothing more than SSG directly connecting the damage to the gambit.

Power Attack converts into Low Quick Sweep bleed. Which, prior to new LI and massive dots nerf which came in the same patch, was 2nd strongest warden DoT. Just fyi. As you seem not to play warden competetively if you express your opinion of Power Attack as useless.

Regarding plugins, maybe in some of them it is set by the plugin dev, but in popular BuffBars + CA combo player sets triggers on his/her own. And with both the application attack nd the DoT of it having the 'Power Attack' line in it, it is made impossible to track the 28 sec dot duration as each DoT tick now refreshes that timer, which it didnt do before the patch as the names were different, and that worked just fine.

[Hyos]

Power Attack converts into Low Quick Sweep bleed. Which, prior to new LI and massive dots nerf which came in the same patch, was 2nd strongest warden DoT. Just fyi. As you seem not to play warden competetively if you express your opinion of Power Attack as useless.

Regarding plugins, maybe in some of them it is set by the plugin dev, but in popular BuffBars + CA combo player sets triggers on his/her own. And with both the application attack nd the DoT of it having the 'Power Attack' line in it, it is made impossible to track the 28 sec dot duration as each DoT tick now refreshes that timer, which it didnt do before the patch as the names were different, and that worked just fine.

You should be able to have one trigger react to "Power Attack on" and another react to "Power Attack Bleed" - these are again mutually exclusive. This change should not be reverted.

[l6rp24e57]

You should be able to have one trigger react to "Power Attack on" and another react to "Power Attack Bleed" - these are again mutually exclusive. This change should not be reverted.

I tried that. Maybe not quite carefully so will definitely retry, but i did. It looks like the plugin engine cuts out the standardized pattern text from char name to '...hit with' and then from 'on <target>' to '...of Morale', and executes the search for the text which fires the trigger only between those. Maybe i am wrong and just messed with setting up myself, subject to test again at least. Probably will test by setting the trigger for smth elsewhere in the line, like 'critical hit' maybe

[Joedangod]

This should have been at least mentioned in the patchnote, but better if this was reverted. Having the same name on the DoT as it is on the DoT-applying attack cross-interferes the triggers on DoT tracking plugins and renders some of them unusable/malfunctioning.

As a plugin author I'm not seeing the issue here?

The DoT has a different name from the initial hit. I suppose you might see some issue if you're using a basic string.find to search for "Mighty Blow" alone but that's the con of going that route over a more robust system that pulls the full name of the ability rather than doing a partial match.

[l6rp24e57]

As a plugin author I'm not seeing the issue here?

The DoT has a different name from the initial hit. <...> find to search for "Mighty Blow" alone

I am quite sure that buffbars does not support regular expressions in order to prevent the string with 'bleed' word from firing the trigger. Probably will have to retry the search for '[skill]+on' as posted above.